Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdaniels/case insensitive search #925

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

bdaniels/case insensitive search #925

wants to merge 9 commits into from

Conversation

barrydaniels-nl
Copy link
Contributor

Don't forget about...

  • Tests
  • Documentation in dev-docs/
  • Readable commit messages explaining the reason for changes

Replace this text with a summary of the PR.
Use AB#xyz to reference issue xyz on Azure DevOps.

vdboor
vdboor reviewed Jan 13, 2025
View reviewed changes
src/dso_api/dynamic_api/filters/lookups.py Outdated Show resolved Hide resolved
src/dso_api/dynamic_api/filters/parser.py Outdated Show resolved Hide resolved
src/dso_api/dynamic_api/filters/parser.py Outdated Show resolved Hide resolved
src/dso_api/dynamic_api/filters/parser.py Outdated Show resolved Hide resolved
vdboor
vdboor previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@vdboor vdboor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Op zich prima, klein puntje wel gezien.

En vraagje, moeten we nog indexen maken? (CREATE INDEX name_ic_idx ON lower(name))

src/dso_api/dynamic_api/filters/lookups.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdboor vdboor vdboor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrydaniels-nl @vdboor