Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add collapsible menu to Header #1784

Merged
merged 64 commits into from
Dec 20, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Dec 10, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It adds a collapsible menu to Header and changes the API accordingly.

Why

Header was incomplete, we couldn't make a functional Header yet.

How

It's quite a rework of the old component. It adds a menu button to the component, and adds children for the content of the collapsible menu.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Header has a NarrowScreenOnlyGridCell subcomponent, maybe we can improve that name
  • Header is supposed to get extra block space. ams.space.grid.md was chosen, but that looks awkward imo. I chose ams.space.grid.sm now, but that's something we should discuss.
  • Should the collapsible menu have fixed top and bottom spacing?
  • Spacing in general is something which should be checked by design, it wasn't always clear what it should be.

@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 17, 2024 16:31 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 18, 2024 08:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 18, 2024 10:33 Destroyed
@alimpens alimpens marked this pull request as ready for review December 18, 2024 10:34
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 18, 2024 10:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 20, 2024 15:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 20, 2024 15:46 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 20, 2024 15:58 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 20, 2024 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-884-update-header December 20, 2024 16:18 Destroyed
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alea iacta est!

@VincentSmedinga VincentSmedinga merged commit 44ce6d8 into develop Dec 20, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-884-update-header branch December 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants