-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add collapsible menu to Header #1784
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 17, 2024 16:31
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 18, 2024 08:50
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 18, 2024 10:33
Destroyed
…into feat/DES-884-update-header
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 18, 2024 10:36
Destroyed
alimpens
commented
Dec 18, 2024
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 20, 2024 15:44
Destroyed
…rdam/design-system into feat/DES-884-update-header
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 20, 2024 15:46
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 20, 2024 15:58
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 20, 2024 16:03
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-884-update-header
December 20, 2024 16:18
Destroyed
VincentSmedinga
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alea iacta est!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It adds a collapsible menu to Header and changes the API accordingly.
Why
Header was incomplete, we couldn't make a functional Header yet.
How
It's quite a rework of the old component. It adds a menu button to the component, and adds children for the content of the collapsible menu.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
ams.space.grid.md
was chosen, but that looks awkward imo. I choseams.space.grid.sm
now, but that's something we should discuss.