Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure pnpm version for corepack #1659

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Robbert
Copy link
Contributor

@Robbert Robbert commented Oct 14, 2024

Describe the pull request

Add code to support corepack enable

What

Support for corepack enable

Why

Your pnpm version is incompatible with "/Users/bobby/Sites/github.com/Amsterdam/design-system".

Expected version: ^9
Got: 8.15.8

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

How

Add packageManager property to package.json

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

@alimpens alimpens changed the title build: configure pnpm version for corepack chore: configure pnpm version for corepack Oct 15, 2024
@alimpens alimpens self-requested a review October 15, 2024 15:09
package.json Outdated Show resolved Hide resolved
@alimpens alimpens merged commit 2485117 into Amsterdam:develop Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants