Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not show transparent border in Storybook in forced colors mode #1577

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It hides a transparent border that Storybook sets, which incorrectly shows in forced color mode.

Why

We want to support forced colors mode, this makes sure it also looks good in Storybook.

How

By giving the border a Canvas system color when in forced colors mode.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@VincentSmedinga VincentSmedinga merged commit a05dc41 into develop Sep 11, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the sb-forced-colors branch September 11, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants