Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use prsid as identifier and not rsin (rsin is not unique) #783

Merged
merged 4 commits into from
Aug 21, 2023
Merged

use prsid as identifier and not rsin (rsin is not unique) #783

merged 4 commits into from
Aug 21, 2023

Conversation

brahim-cher
Copy link
Contributor

@brahim-cher brahim-cher commented Aug 17, 2023 •
edited
Loading

rsin is not unique is the source data. prsid is now used as identifier in NNP and as reference in MAC.

@brahim-cher brahim-cher marked this pull request as ready for review August 17, 2023 14:22
@brahim-cher brahim-cher requested a review from a team as a code owner August 17, 2023 14:22
jjmurre
jjmurre approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jjmurre jjmurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjmurre jjmurre merged commit 62c340b into master Aug 21, 2023
1 check passed
@jjmurre jjmurre deleted the 89746-use-prsid-as-identificatie-NNP branch August 21, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmurre jjmurre jjmurre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brahim-cher @jjmurre