feat: Update Concat function to accept any type

AmrDeveloper · Dec 28, 2023 · d5b1a0b · d5b1a0b
1 parent 9cef9d2
commit d5b1a0b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/crates/gitql-ast/src/function.rs b/crates/gitql-ast/src/function.rs
@@ -227,7 +227,7 @@ lazy_static! {
         map.insert(
             "concat",
             Prototype {
-                parameters: vec![DataType::Text, DataType::Text, DataType::Varargs(Box::new(DataType::Text))],
+                parameters: vec![DataType::Any, DataType::Any, DataType::Varargs(Box::new(DataType::Any))],
                 result: DataType::Text
              },
         );
@@ -642,7 +642,7 @@ fn text_soundex(inputs: &[Value]) -> Value {
 }
 
 fn text_concat(inputs: &[Value]) -> Value {
-    let text: Vec<String> = inputs.iter().map(|v| v.as_text()).collect();
+    let text: Vec<String> = inputs.iter().map(|v| v.to_string()).collect();
     Value::Text(text.concat())
 }
 

diff --git a/docs/function/functions.md b/docs/function/functions.md
@@ -26,7 +26,7 @@ note that all functions names are case-insensitive.
 | RIGHT      | Text, Integer                | Text    | Extracts a number of characters from a string (starting from right).                                                                                                 |
 | TRANSLATE  | Text, Text, Text,            | Text    | Returns the string from the first argument after the characters specified in the second argument are translated into the characters specified in the third argument. |
 | SOUNDEX    | Text                         | Text    | Returns a four-character code to evaluate the similarity of two expressions.                                                                                         |
-| CONCAT     | Text, Text, ...Text          | Text    | Adds two or more strings together.                                                                                                                                   |
+| CONCAT     | Any, Any, ...Any             | Text    | Add several string representations of values together together.                                                                                                      |
 | UNICODE    | Text                         | Integer | Return an integer value (the Unicode value), for the first character of the input expression.                                                                        |
 
 ### String functions samples