Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX, Typescript, Mantine UI #145

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

MDX, Typescript, Mantine UI #145

wants to merge 29 commits into from

Conversation

sakgoyal
Copy link
Collaborator

@sakgoyal sakgoyal commented Feb 19, 2024

  • use MDX instead of MD to drastically simplify code.

  • use typescript instead of javascript (.tsx vs .jsx)
  • stage mantine prebuilt UI library
  • fix a few errors

Mantine also has built in dark mode

@sakgoyal sakgoyal self-assigned this Feb 19, 2024
@sakgoyal sakgoyal added enhancement New feature or request needs_work labels Feb 19, 2024
@Forsyth-Creations
Copy link
Contributor

I think overall I like the idea of typescript, but with it being strongly typed I worry about whoever might be picking up the webdev side of things once I'm gone. Javascript has a much lower barrier of entry. What do you think?

Also, have you played with MUI at all? Great framework

@sakgoyal
Copy link
Collaborator Author

typescript for me is just a really good linter for javascript. its slightly more complicated, but I feel it's very easy to pick up and helps avoid common mistakes.
I have not used MUI at all. but I have extensive experience with Mantine, which I like because it has very similar styling to tailwind.

@sakgoyal sakgoyal changed the title use typescript and stage mantine UI Typescript and mantine UI Feb 22, 2024
@sakgoyal sakgoyal changed the title Typescript and mantine UI MDX, Typescript, Mantine UI Mar 6, 2024
@sakgoyal sakgoyal marked this pull request as ready for review March 28, 2024 08:20
@Forsyth-Creations
Copy link
Contributor

@sakgoyal Finally had a chance to review this. I'm really liking the updates! The format will need to be worked on, but once you knock that out I'd be happy to approve it. Resolved some of your merge conflicts so you can keep up the great work!

@Forsyth-Creations
Copy link
Contributor

Forsyth-Creations commented Apr 10, 2024

image

^ I really like the look of this

@sakgoyal
Copy link
Collaborator Author

@Forsyth-Creations I didn't realize you force pushed. my commits reverted your changes. I think you will need to redo those changes if they are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs_work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants