Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper function for getting Savefilepath #13

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

silverhadch
Copy link
Contributor

Repeated logic implemnted in a clean and better way. !!!! But please test the code i havent yet just wrote it on my Phone !!!!

Repeated logic implemnted in a clean and better way. 
!!!! But please test the code i havent yet just wrote it on my Phone !!!!
plastic_tui/src/ui.rs Outdated Show resolved Hide resolved
plastic_tui/src/ui.rs Outdated Show resolved Hide resolved
plastic_tui/src/ui.rs Outdated Show resolved Hide resolved
plastic_tui/src/ui.rs Outdated Show resolved Hide resolved
plastic_tui/src/ui.rs Outdated Show resolved Hide resolved
@silverhadch
Copy link
Contributor Author

For Linux a Test returns:
{"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 3316s."}

Is that something to worry about the commit or a general error?

@Amjad50
Copy link
Owner

Amjad50 commented Oct 23, 2024

For Linux a Test returns: {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 3316s."}

Is that something to worry about the commit or a general error?

you can ignore this, its with codecov, I'll fix it later.

@Amjad50
Copy link
Owner

Amjad50 commented Oct 23, 2024

Anyway thanks for this!

I'll merge it

@Amjad50 Amjad50 enabled auto-merge (squash) October 23, 2024 07:29
@Amjad50 Amjad50 disabled auto-merge October 23, 2024 07:32
@Amjad50 Amjad50 merged commit 4f38bff into Amjad50:master Oct 23, 2024
1 of 2 checks passed
@silverhadch silverhadch deleted the patch-1 branch October 23, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants