Skip to content

Campaign(s) remaining (redis) #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elpiel opened this issue Jul 14, 2021 · 1 comment · Fixed by #418
Closed

Campaign(s) remaining (redis) #415

elpiel opened this issue Jul 14, 2021 · 1 comment · Fixed by #418
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Jul 14, 2021

Since we need to use the calls to redis in multiple occasions ( #413 & #408 )

Create a single struct (sentry::db::campaign::CampaignRemaining) that handles the key & have all required calls we need for Redis (for creating & modifying campaign as well as Events recording).
This will remove duplicate logic and some error prone places (like having the redis key twice on 2 different locations)

@elpiel elpiel added this to the sentry-v0.2.0 milestone Jul 14, 2021
@elpiel elpiel changed the title Campaign remaining Campaign(s) remaining Jul 14, 2021
@elpiel elpiel changed the title Campaign(s) remaining Campaign(s) remaining (redis) Jul 14, 2021
@elpiel elpiel linked a pull request Aug 9, 2021 that will close this issue
elpiel added a commit that referenced this issue Aug 9, 2021
Issue #415 Create/Modify Campaigns - Redis and tests
@elpiel
Copy link
Member Author

elpiel commented Aug 10, 2021

CampaignRemaining is now used in the following places:

@elpiel elpiel closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant