RateLimit and redis randomly failing tests #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

3 tasks done

elpiel opened this issue Dec 21, 2020 · 1 comment · Fixed by #372

Closed

3 tasks done

RateLimit and redis randomly failing tests #357

elpiel opened this issue Dec 21, 2020 · 1 comment · Fixed by #372

Assignees

Labels

bug

Milestone

Member

elpiel commented Dec 21, 2020 •

edited

Loading

We currently hit the RateLimit from sentry::access::check_access in tests (ran asynchronously) quite often as it's they are timed tests.

Make sure for each test in access.rs to setup a different Database in order to not have random failing tests
improve the usability of redis_connection
enable ignored tests from PR Issue 335 update targeting event #352 (issue AIP#31 Event::UpdateTargeting (UPDATE_TARGETING) #335)

The text was updated successfully, but these errors were encountered:

elpiel added the bug label

elpiel added this to the sentry-v0.2.0 milestone

simzzz self-assigned this

simzzz mentioned this issue

Running sentry tests no longer hits redis rate limit #372

Merged

Member Author

elpiel commented Mar 19, 2021

Resolved in #372

elpiel closed this as completed

elpiel linked a pull request

that will close this issue

Running sentry tests no longer hits redis rate limit #372

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment