Skip to content

Payout is prone to overflow #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elpiel opened this issue Apr 6, 2020 · 1 comment
Closed

Payout is prone to overflow #291

elpiel opened this issue Apr 6, 2020 · 1 comment
Labels
enhancement New feature or request Mid
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Apr 6, 2020

In #290 we've introduced Multiplier Price bounds for payouts, this code is known that it can cause overflow at the moment.
The value of the multiplier has been restricted in JS, so this shouldn't cause any major issue right now, but it's a know issue that needs to be handled.

Return an Error instead or other solution (e.g. default value in case of overflow) to handle this issue in the long run.

https://github.com/AdExNetwork/adex-validator-stack-rust/blob/d2348ccaa057ad9ba6193d93c59c2f2eb5b70e46/sentry/src/payout.rs#L48

@elpiel elpiel added enhancement New feature or request Mid labels Apr 6, 2020
@elpiel
Copy link
Member Author

elpiel commented Jul 16, 2020

Closing in favour of #323

@elpiel elpiel closed this as completed Jul 16, 2020
@elpiel elpiel added this to the sentry-v0.2.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Mid
Projects
None yet
Development

No branches or pull requests

1 participant