Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub ci #136

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: GitHub ci #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
lint_js:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: ".tool-versions"
cache: "yarn"
Expand All @@ -22,7 +22,7 @@ jobs:
lint_ruby:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
bundler: default
Expand All @@ -47,8 +47,8 @@ jobs:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: ".tool-versions"
cache: "yarn"
Expand All @@ -63,13 +63,14 @@ jobs:
rubygems: latest
- name: Run test
run: bundle exec rake test:system
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
path: |
/home/runner/work/view_components/view_components/demo/tmp/capybara/
if-no-files-found: ignore
retention-days: 7
overwrite: true

test_components:
needs:
Expand All @@ -87,7 +88,7 @@ jobs:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand All @@ -96,22 +97,3 @@ jobs:
rubygems: latest
- name: Run test
run: bundle exec rake test:components

test_js:
needs:
- lint_js
- lint_ruby
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version-file: ".tool-versions"
cache: "yarn"
- name: Install playwright
run: npx playwright install --with-deps
- name: Run test
run: |
yarn install --frozen-lockfile
yarn build:js
yarn test