fix(workspace): add tsconfig.json dedicated to the application #2650
Conversation
|
View your CI Pipeline Execution ↗ for commit 35782f5.
☁️ Nx Cloud last updated this comment at |
kpanot
force-pushed
the
bugfix/missing-app-tsconfig
branch
4 times, most recently
from
5d68e48 to
c567544
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
kpanot
force-pushed
the
bugfix/missing-app-tsconfig
branch
2 times, most recently
from
8525544 to
adf2777
Compare
| * @param files List of files to look for, the first of the list will be used | ||
| * @param originPath Path from where to calculate the relative path | ||
| */ | ||
| function findConfigFileRelativePath(tree: Tree, files: string[], originPath: string) { |
There was a problem hiding this comment.
Is this method just for config file? It seems like it can work with any kind of files.
There was a problem hiding this comment.
This is a duplication of the function in @o3r/schematics.
There is an issue in the import of @o3r/schematics (maybe due to ESM/CJS convertion?)
Added note to explain it
| { | ||
| "extends": "<%= tsconfigBasePath %>", | ||
| "references": [ | ||
| {"path": "./tsconfig.app.json"}, |
There was a problem hiding this comment.
Is this file generated by angular?
packages/@o3r/workspace/schematics/application/templates/tsconfig.json.template
Show resolved
Hide resolved
kpanot
force-pushed
the
bugfix/missing-app-tsconfig
branch
from
adf2777 to
35782f5
Compare
Proposed change
fix(workspace): add tsconfig.json dedicated to the application
Related issues