Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Allow VsCode extension without espree detection #2647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Dec 23, 2024

Proposed change

Allow the VsCode extension to be loaded without espree detection
This PR is not a proper fix of the lack of espree dependency but unlock the extension run

Related issues

@kpanot kpanot requested a review from a team as a code owner December 23, 2024 03:31
@kpanot kpanot force-pushed the bugfix/vscode-eslint branch from 6807d04 to 1ccc6a6 Compare December 23, 2024 03:34
Copy link

nx-cloud bot commented Dec 23, 2024

View your CI Pipeline Execution ↗ for commit 34533ca.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 56m 24s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 52s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 5s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded 34s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 05:08:28 UTC

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (c8834dc) to head (34533ca).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot force-pushed the bugfix/vscode-eslint branch from 1ccc6a6 to 7fd67c1 Compare December 23, 2024 03:58
@kpanot kpanot force-pushed the bugfix/vscode-eslint branch from 7fd67c1 to 34533ca Compare December 23, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant