Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DueBefore to /active instances endpoint #179

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Feb 1, 2023

This is the same as #177, but to add DueBefore in addition to PresentationValues

It seems obvious that due date is just as relevant as PresentationValues in this view.

CC: @tjololo

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

This is the same as Altinn#177,
but to add DueBefore in addition to PresentationValues
@tjololo tjololo added external-contribution-❤️ Pull request from a developer outside the Altinn teams. feature Label Pull requests with new features. Used when generation releasenotes labels Feb 1, 2023
@tjololo tjololo self-assigned this Feb 1, 2023
@tjololo
Copy link
Member

tjololo commented Feb 1, 2023

Just a quick check, do we cover both with value and without value in the tests?

@ivarne
Copy link
Member Author

ivarne commented Feb 1, 2023

Actually I forgot to add DueBefore to one of the test cases. It is added now.

@tjololo tjololo merged commit 86c7e3d into Altinn:main Feb 1, 2023
@ivarne ivarne deleted the dueBefore_ACTIVE branch February 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution-❤️ Pull request from a developer outside the Altinn teams. feature Label Pull requests with new features. Used when generation releasenotes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants