Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Designsystemet instead of altinn/designsystem for Pagination #2980

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

paal2707
Copy link
Contributor

@paal2707 paal2707 commented Feb 6, 2025

Description

Use Designsystemet instead of altinn/designsystem for Pagination on InstanceSelection and ListComponent.
Made a component in app-components for pagination that wraps the Designsystemet Pagination component, used this on the InstanceSelectionComponent and ListComponent

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@paal2707 paal2707 added the kind/other Pull requests containing chores/repo structure/other changes label Feb 6, 2025
@@ -61,10 +61,13 @@ describe('List component', () => {

cy.get(dataListPage.listComponent).get(dataListPage.selectComponent).should('have.value', '5');
cy.get(dataListPage.listComponent).get(dataListPage.tableBody).find('tr').its('length').should('eq', 5);
cy.get(dataListPage.listComponent).get(dataListPage.selectComponent).select('10');
//cy.get(dataListPage.listComponent).get(dataListPage.selectComponent).select('10');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fjern kommentar?

@paal2707 paal2707 merged commit f9c9e66 into main Feb 6, 2025
15 checks passed
@paal2707 paal2707 deleted the chore/Remove-old-altinn-design-system branch February 6, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants