feat(grafana): create access for dialogporten devs #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe changes involve updating the Grafana configuration in the Terraform file for the Altinn Monitor Test Resource Group. Two new local variables representing Dialogporten developer groups are introduced, with specific GUID values. These variables are then added to the existing Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf (1)
77-79: LGTM! Consider documenting access permissions.The addition of Dialogporten developer groups to the Grafana editors list is appropriate and follows existing patterns. Since this introduces new access permissions, consider:
- Documenting these permissions in the relevant documentation
- Adding a description of the access level granted to Dialogporten developers
Would you like me to help create a documentation PR in the altinn-studio-docs repository as mentioned in the PR checklist?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf (1)
68-69: Verify Azure AD group IDs for Dialogporten developersThe GUIDs appear to be Azure AD group IDs. Let's verify they correspond to the correct Dialogporten developer groups.
✅ Verification successful
Implementation of Dialogporten developer groups follows established patterns
The new Dialogporten developer groups are correctly integrated into the Grafana configuration:
- Follow consistent naming convention with other developer groups
- Properly assigned Grafana Editor permissions
- Part of a complete Dialogporten integration setup
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify Azure AD group IDs exist and match the expected groups # Note: This requires Azure CLI authentication # Check dialogporten_developers group echo "Checking dialogporten_developers group (857b3aa1-bde3-469c-a052-a24c81503646):" az ad group show --group 857b3aa1-bde3-469c-a052-a24c81503646 --query "displayName" 2>/dev/null # Check dialogporten_developers_prod group echo "Checking dialogporten_developers_prod group (415cfc7b-40f6-4540-9aef-cb9c9050aada):" az ad group show --group 415cfc7b-40f6-4540-9aef-cb9c9050aada --query "displayName" 2>/dev/nullLength of output: 511
Script:
#!/bin/bash # Search for the Dialogporten developer group IDs across the codebase echo "Searching for dialogporten_developers group ID:" rg -l "857b3aa1-bde3-469c-a052-a24c81503646" echo -e "\nSearching for dialogporten_developers_prod group ID:" rg -l "415cfc7b-40f6-4540-9aef-cb9c9050aada" echo -e "\nChecking for similar Grafana configuration patterns:" fd "grafana.tf" --type fLength of output: 665
Script:
#!/bin/bash # Examine the complete grafana.tf file to understand the context echo "Checking complete grafana.tf content:" cat infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf echo -e "\nChecking for similar group ID patterns:" rg -A 1 -B 1 '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}' infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tfLength of output: 7766
monteiro-renato
approved these changes
Jan 7, 2025
Terraform environment testFormat and Style 🖌
|
| Context | Values |
|---|---|
| Pusher | @sduranc |
| Action | push |
| Working Directory | ./infrastructure/adminservices-test/altinn-monitor-test-rg |
| State File | github.com/altinn/altinn-platform/environments/test/altinn-monitor-test-rg.tfstate |
| Plan File | github.com_altinn_altinn-platform_environments_test_altinn-monitor-test-rg.tfstate.tfplan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation
Summary by CodeRabbit