Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endret response til json for initialize og upload #547

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

mSunberg
Copy link
Collaborator

Description

This code changes the response for initialize and upload from text to json.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Copy link
Collaborator

@Ceredron Ceredron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of tests are failing. I think it is because FileTransferId has changed from string to object so everywhere that gets a FileTransferId needs to update. But it should only be a few helper functions. For instance, in FileTransferControllerTests/InitializeAndAssertBasicFileTransfer
It tries to get FileTransferId like this:
return await initializeFileTransferResponse.Content.ReadAsStringAsync();
But should be:

var fileTransferResponse = await initializeFileTransferResponse.Content.ReadFromJsonAsync();
return fileTransferResponse.FileTransferId;

@mSunberg mSunberg merged commit 89c48d9 into main Oct 7, 2024
5 checks passed
@mSunberg mSunberg deleted the chore/setAPIResponseJson branch October 7, 2024 11:07
@mSunberg mSunberg linked an issue Oct 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alltid returner application/json
3 participants