Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle and kotlin version #1132

Closed
wants to merge 1 commit into from

Conversation

paolorotolo
Copy link
Contributor

Update gradle and kotlin version of the library to allow building with the latest tools.

@davidgyoung
Copy link
Member

Thanks for the updates. I am going to have to wait to merge this until I can get it gradle 7 working with the reference app https://github.com/davidgyoung/android-beacon-library-reference-kotlin/tree/wip-upgrade-gradle-7 which is having some build compatibility trouble with gradle 7. I need the build tools to be in sync on both projects because I use it to verify the library functionality when the library is configured as a gradle subproject.

@paolorotolo
Copy link
Contributor Author

Ah, I did open a pull on the java reference app too: AltBeacon/android-beacon-library-reference#66
I used it to test the new changes with the library submodule.

I didn't notice the Kotlin porting, maybe you could cherry-pick the updates from the java reference pull

@davidgyoung
Copy link
Member

Thank you @paolorotolo, I copied in many of your changes to get this working in the branch in a new PR here: #1150, which finally has this working with the reference app.

@davidgyoung davidgyoung closed this Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants