Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle walletconnect deeplinks #3311

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

JamesSmartCell
Copy link
Member

  • handle walletconnect deeplinks.
  • Refactor start intent handling.
  • Add start intent/deeplink handling unit tests.

Closes #3274

- Refactor start intent handling
- Add start intent/deeplink handling unit tests
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage is 58.62% of modified lines.

❗ Current head dd01677 differs from pull request most recent head 27e08f1. Consider uploading reports for the commit 27e08f1 to get more accurate results

Files Changed Coverage
...llet/app/entity/attestation/ImportAttestation.java ø
...main/java/com/alphawallet/app/ui/HomeActivity.java 0.00%
...a/com/alphawallet/app/service/DeepLinkService.java 84.09%
...wallet/app/api/v1/entity/request/ApiV1Request.java 90.90%
...va/com/alphawallet/app/entity/DeepLinkRequest.java 100.00%
.../java/com/alphawallet/app/entity/DeepLinkType.java 100.00%
.../src/main/java/com/alphawallet/app/util/Utils.java 100.00%

📢 Thoughts on this report? Let us know!.

@JamesSmartCell JamesSmartCell merged commit 6db4ff3 into master Sep 25, 2023
8 checks passed
@JamesSmartCell JamesSmartCell deleted the handle-walletconnect-deeplinks branch September 25, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support awallet://wc?uri=wc%3Axxx in addition to wc: making them do the same thing
1 participant