-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Send #3229
base: master
Are you sure you want to change the base?
Improve Send #3229
Conversation
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
app/src/main/java/com/alphawallet/app/ui/widget/adapter/SelectLifiTokenAdapter.java
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/ui/widget/adapter/SelectLifiTokenAdapter.java
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3229 +/- ##
===========================================
- Coverage 7.57% 7.57% -0.01%
- Complexity 906 931 +25
===========================================
Files 659 672 +13
Lines 44943 45832 +889
Branches 4534 4620 +86
===========================================
+ Hits 3404 3470 +66
- Misses 41249 42047 +798
- Partials 290 315 +25
☔ View full report in Codecov by Sentry. |
As discussed earlier this year, one of the major pain points of the Send flow was that it took 8 steps to reach the confirmation screen. This PR addresses that issue, which reduces the baseline scenario to 6 steps. Other quality of life improvements are also implemented:
InputAmount
error message moved to the left so it no longer hides the 'All Funds' button. Also matchesInputAddress
error message location.ChainName
view for a cleaner look