Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Send #3229

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Improve Send #3229

wants to merge 33 commits into from

Conversation

justindg
Copy link
Contributor

@justindg justindg commented May 12, 2023


As discussed earlier this year, one of the major pain points of the Send flow was that it took 8 steps to reach the confirmation screen. This PR addresses that issue, which reduces the baseline scenario to 6 steps. Other quality of life improvements are also implemented:

  • New: User can now select a different token from the Send screen. Previously you had to go back to wallet tab and re-do all steps.
  • New: Added Send button to the bottom navigation bar. In this scenario, the token selection screen is immediately shown, with the search bar focused as well.
  • New: Last sent token is added on top of token selection list. This creates a best case scenario of only 5 steps to reach confirmation screen.
  • New: Fiat equivalent value is now shown below the input box, which recalculates on user input.
  • Rework: Added a new button for crypto-fiat switch. Clicking on the token now brings up token selection.
  • Rework: Payment/transfer request (EIP-681) is now on a separate activity. Refactored for readability. On this mode, all fields can no longer be edited.
  • Rework: InputAmount error message moved to the left so it no longer hides the 'All Funds' button. Also matches InputAddress error message location.
  • Rework: Updated ChainName view for a cleaner look
  • Other: Fixed other UI issues

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
6
▀▀▀▀
1d 3h 34m
▀▀▀▀▀
21
▀▀▀▀▀▀▀▀▀▀
JamesSmartCell
🥈
7
▀▀▀▀
21h 40m
▀▀▀▀
0
justindg
🥉
4
▀▀
1h 42m
0

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 3.92% and project coverage change: -0.01 ⚠️

Comparison is base (998bf80) 7.57% compared to head (1fedd54) 7.57%.

❗ Current head 1fedd54 differs from pull request most recent head 98ca6e5. Consider uploading reports for the commit 98ca6e5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3229      +/-   ##
===========================================
- Coverage      7.57%   7.57%   -0.01%     
- Complexity      906     931      +25     
===========================================
  Files           659     672      +13     
  Lines         44943   45832     +889     
  Branches       4534    4620      +86     
===========================================
+ Hits           3404    3470      +66     
- Misses        41249   42047     +798     
- Partials        290     315      +25     
Impacted Files Coverage Δ
app/src/main/java/com/alphawallet/app/C.java 57.14% <ø> (ø)
...n/java/com/alphawallet/app/entity/Transaction.java 6.97% <0.00%> (-0.28%) ⬇️
...n/java/com/alphawallet/app/entity/lifi/Action.java 100.00% <ø> (ø)
...va/com/alphawallet/app/entity/lifi/Connection.java 0.00% <ø> (ø)
.../java/com/alphawallet/app/entity/lifi/FeeCost.java 0.00% <ø> (ø)
.../java/com/alphawallet/app/entity/lifi/GasCost.java 100.00% <ø> (ø)
...phawallet/app/entity/notification/DataMessage.java 0.00% <0.00%> (ø)
.../java/com/alphawallet/app/entity/tokens/Token.java 10.41% <0.00%> (+10.41%) ⬆️
...awallet/app/entity/transactions/TransferEvent.java 0.00% <0.00%> (ø)
...va/com/alphawallet/app/router/SendTokenRouter.java 0.00% <0.00%> (ø)
... and 64 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justindg justindg changed the title [WIP] Improve Send Improve Send May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Send
1 participant