Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2850 no more api23 support #3088

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

seabornlee
Copy link
Contributor

  • Remove version check code
  • Use original web3j lib
  • Use stream API anyMatch
  • Use Stream.mapToInt
  • Use stream API
  • Use stream API filter.count
  • Use stream API mapToInt
  • Use stream mapToInt
  • Refactor: elimate for loop duplication
  • Use stream noneMatch API
  • Use stream findFirst API

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
7
▀▀▀
4h 53m
▀▀
3
▀▀▀▀
JamesSmartCell
🥈
12
▀▀▀▀▀
16h 10m
▀▀▀▀▀▀
2
▀▀▀
hboon
🥉
2
3h 25m
1
justindg
1
1h 11m
1

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 7.70% // Head: 7.96% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (dbbc402) compared to base (9243ab5).
Patch coverage: 8.41% of modified lines in pull request are covered.

❗ Current head dbbc402 differs from pull request most recent head 222ef86. Consider uploading reports for the commit 222ef86 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3088      +/-   ##
===========================================
+ Coverage      7.70%   7.96%   +0.25%     
- Complexity      887     925      +38     
===========================================
  Files           648     649       +1     
  Lines         43463   43500      +37     
  Branches       4380    4378       -2     
===========================================
+ Hits           3350    3463     +113     
+ Misses        39828   39743      -85     
- Partials        285     294       +9     
Impacted Files Coverage Δ
...ava/com/alphawallet/app/entity/EtherscanEvent.java 5.00% <0.00%> (-3.34%) ⬇️
...com/alphawallet/app/entity/TransactionDecoder.java 56.03% <0.00%> (+0.21%) ⬆️
...om/alphawallet/app/entity/tokens/ERC1155Token.java 0.00% <0.00%> (ø)
.../java/com/alphawallet/app/entity/tokens/Token.java 6.34% <0.00%> (+6.34%) ⬆️
...t/app/entity/transactionAPI/TransferFetchType.java 0.00% <0.00%> (ø)
...lphawallet/app/repository/EthereumNetworkBase.java 46.51% <ø> (ø)
...om/alphawallet/app/repository/TokenRepository.java 5.12% <0.00%> (-0.04%) ⬇️
...lphawallet/app/service/AssetDefinitionService.java 5.82% <0.00%> (+<0.01%) ⬆️
...n/java/com/alphawallet/app/service/KeyService.java 0.73% <0.00%> (+0.01%) ⬆️
.../java/com/alphawallet/app/ui/AddTokenActivity.java 0.00% <0.00%> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant