CustomSettings Implementation #2949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keval-finimble
commented
Nov 16, 2022
keval-finimble
commented
- Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings.
- Added other fields in the json and call them directly from the json file in CustomSettings.
added 2 commits
November 15, 2022 16:54
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
Pull reviewers statsStats of the last 30 days for alpha-wallet-android:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/src/main/java/com/alphawallet/app/di/RepositoriesModule.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/ui/widget/adapter/TokensAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/alphawallet/app/ui/SellDetailActivity.java
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 7.62% // Head: 7.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
===========================================
+ Coverage 7.62% 7.68% +0.05%
- Complexity 836 856 +20
===========================================
Files 612 639 +27
Lines 41863 42918 +1055
Branches 4226 4310 +84
===========================================
+ Hits 3194 3300 +106
- Misses 38395 39346 +951
+ Partials 274 272 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 8 commits
November 16, 2022 19:35
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
… into 2758-feature-customisation-json # Conflicts: # app/src/main/java/com/alphawallet/app/service/PriceAlertsService.java # app/src/main/java/com/alphawallet/app/viewmodel/WalletViewModel.java
app/src/androidTest/java/com/alphawallet/app/CustomSettingsTest.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/alphawallet/app/CustomSettingsTest.java
Outdated
Show resolved
Hide resolved
added 10 commits
November 22, 2022 19:52
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
…ectly from Activity and Fragments. - Enhanced the cache functionality by changing the return type of lockedTokens in CustomSettings. - Added other fields in the json and call them directly from the json file in CustomSettings.
…ed a new function to load lockedChains, lockedTokens and exclusiveChains.
… into 2758-feature-customisation-json # Conflicts: # app/src/main/java/com/alphawallet/app/service/PriceAlertsService.java # app/src/main/java/com/alphawallet/app/ui/AssetDisplayActivity.java # app/src/main/java/com/alphawallet/app/ui/HomeActivity.java # app/src/main/java/com/alphawallet/app/ui/NFTAssetsFragment.java # app/src/main/java/com/alphawallet/app/ui/widget/adapter/NonFungibleTokenAdapter.java
app/src/main/java/com/alphawallet/app/ui/widget/adapter/TokensAdapter.java
Outdated
Show resolved
Hide resolved
JamesSmartCell
force-pushed
the
master
branch
2 times, most recently
from
a1cfb4f
to
8acd3f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.