Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide map file input option for non-hybrid mode #153 #154

Merged

Conversation

XingerTang
Copy link
Contributor

@XingerTang XingerTang commented Jan 9, 2024

Copy link
Member

@gregorgorjanc gregorgorjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XingerTang minor changes requested;)

@gregorgorjanc
Copy link
Member

@XingerTang one final request - we should list changes in the NEWS/CHANGELOG file. Please do this - I hope to remember for every merged PR from now onwards;) It is easier this way than later going over the list of commits;) Thanks for all these contributions.

@XingerTang
Copy link
Contributor Author

@gregorgorjanc Sure!

@XingerTang
Copy link
Contributor Author

@gregorgorjanc Can you create a new branch feat_recomb_new_changelog so that I can open a separate pull request for the log files? Thanks!

@gregorgorjanc
Copy link
Member

@gregorgorjanc Can you create a new branch feat_recomb_new_changelog so that I can open a separate pull request for the log files? Thanks!

@XingerTang done at https://github.com/AlphaGenes/AlphaPeel/tree/feat_recomb_new_changelog

@XingerTang XingerTang mentioned this pull request Jan 11, 2024
@gregorgorjanc
Copy link
Member

@XingerTang thanks for squashing the commit and for this PR! Merging this in!

@gregorgorjanc gregorgorjanc merged commit 383e44f into AlphaGenes:feat_recomb_new Jan 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants