-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add test case for cursor stream bug #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3258883
to
65c9fbd
Compare
1eb74d0
to
919dd86
Compare
b475065
to
4ff030f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to debug and fix this, @seanaye.
Let me know if I missed the mark anywhere and if you want to tackle the comments yourself or if I should just do it - I think I've got a reasonable handle of the changes.
Then finally, the commit history will just need to get cleaned up a bit - I've updated semantic.yml
config so a rebase against master should give you correct status checks. If you add two newlines & Closes #52
to one of the commit messages, it'll show up as the one that resolved the issue in the changelog.
The supported scopes, the type of commit & changelog heading they result in can be found in the changelog action - I'll be sure to add this information to added.CONTRIBUTING.md
shortly
Gotcha, I can make the requested changes tomorrow . Thanks for reviewing! |
021b8b5
to
65bc525
Compare
Found the valid commit types in the yaml |
65bc525
to
47efa70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks again for the PR. I'll just squash the commits up a bit further and get this released shortly
47efa70
to
2284f6d
Compare
Here is a reproduction test case for #52
Edit: I have a fix for the bug
resolves: #52