Skip to content

Add test case for cursor stream bug #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

seanaye
Copy link
Contributor

@seanaye seanaye commented Apr 15, 2025

Here is a reproduction test case for #52

Edit: I have a fix for the bug

resolves: #52

@seanaye seanaye requested a review from Alorel as a code owner April 15, 2025 15:36
@seanaye seanaye force-pushed the seanaye/cursor-stream-bug branch from 3258883 to 65c9fbd Compare April 15, 2025 15:42
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 16, 2025
@seanaye seanaye force-pushed the seanaye/cursor-stream-bug branch 2 times, most recently from 1eb74d0 to 919dd86 Compare April 16, 2025 19:22
@seanaye seanaye force-pushed the seanaye/cursor-stream-bug branch 2 times, most recently from b475065 to 4ff030f Compare April 17, 2025 14:27
Copy link
Owner

@Alorel Alorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to debug and fix this, @seanaye.

Let me know if I missed the mark anywhere and if you want to tackle the comments yourself or if I should just do it - I think I've got a reasonable handle of the changes.

Then finally, the commit history will just need to get cleaned up a bit - I've updated semantic.yml config so a rebase against master should give you correct status checks. If you add two newlines & Closes #52 to one of the commit messages, it'll show up as the one that resolved the issue in the changelog.

The supported scopes, the type of commit & changelog heading they result in can be found in the changelog action - I'll be sure to add this information to CONTRIBUTING.md shortly added.

@Alorel Alorel self-assigned this Apr 19, 2025
@seanaye
Copy link
Contributor Author

seanaye commented Apr 20, 2025

Gotcha, I can make the requested changes tomorrow . Thanks for reviewing!

@seanaye seanaye force-pushed the seanaye/cursor-stream-bug branch 2 times, most recently from 021b8b5 to 65bc525 Compare April 22, 2025 19:57
@seanaye seanaye requested a review from Alorel April 22, 2025 19:59
@seanaye
Copy link
Contributor Author

seanaye commented Apr 22, 2025

I have rebased onto master but the semantic check is still failing? Not sure how to debug that as there is no logs I can see

Found the valid commit types in the yaml

@seanaye seanaye force-pushed the seanaye/cursor-stream-bug branch from 65bc525 to 47efa70 Compare April 22, 2025 20:08
Copy link
Owner

@Alorel Alorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks again for the PR. I'll just squash the commits up a bit further and get this released shortly

@Alorel Alorel force-pushed the seanaye/cursor-stream-bug branch from 47efa70 to 2284f6d Compare April 28, 2025 19:48
@Alorel Alorel enabled auto-merge (rebase) April 28, 2025 19:49
@Alorel Alorel merged commit d518f68 into Alorel:master Apr 28, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Race in Cursor Stream
3 participants