OVHcloud mirror: split into 4 different locations #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This looks perfect. Long term I think being able to list multiple locations per mirror would solve the potential of having to use invalid names that you did here (but is the best solution right now). I'm not 100% sure how the system will react to multiple mirrors listing a common ASN - once an ASN match is hit I don't recall if there is any further logic on them in the case of multiple matches. I believe we've had another recent "issue" with this. Going to hold off on merging this until I can revisit that and make sure this won't cause any issues for your users. |
|
All of the file names need to end in |
sbraz
force-pushed
the
ovhcloud_mirror
branch
2 times, most recently
from
46714da
to
1770a73
Compare
Our anycast IP is routed to 4 different locations. This is a follow-up to 02c8629.
sbraz
force-pushed
the
ovhcloud_mirror
branch
from
1770a73
to
420ca48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonathanspw does this look OK? I'm not a fan of the invalid DNS records for the names but I don't really have a better idea right now.
Our anycast IP is routed to 4 different locations. This is a follow-up to 02c8629.