Relax check_panel_memory actor's check #81
Conversation
The check_panel_memory actor is intended to inhibit upgrades when the system lacks the memory needed to satisfy minimum system requirements for CloudLinux 8, which may vary depending on whether a control panel is installed. However, the actor is using the value for total memory as reported by the kernel, rather than the nominal amount of memory actually installed on the system. Since the kernel subtracts its own memory usage from this total, a nominally minimum-spec machine will always fail this check. To address this, credit the machine with a certain amount of additional memory when performing the check. (This credited amount will not appear in the message if the check still fails.)
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
Hello and thanks for PR. We're going to rebase AlmaLinux's leapp-repository to latest upstream and drop CloudLinux and panels support, see explanation here: |
The
check_panel_memoryactor is intended to inhibit upgrades when the system lacks the memory needed to satisfy minimum system requirements for CloudLinux 8, which may vary depending on whether a control panel is installed. However, the actor is using the value for total memory as reported by the kernel, rather than the nominal amount of memory actually installed on the system. Since the kernel subtracts its own memory usage from this total, a nominally minimum-spec machine will always fail this check, something which does not appear to be intended. To address this, credit the machine with a certain amount of additional memory when performing the check. (This credited amount will not appear in the message if the check still fails.)A limited number of observations showed that the total is around 50-75 MiB when installed memory is 2 GiB. As a reasonable middle ground, I have preliminarily set the credit to 96 MiB, in case additional kernel features are in use which might add to this total. That said, one common kernel feature which reserves a lot of memory is the
crashkernelfeature. Acrashkernel=autoentry on the kernel command line can by itself use over a hundred MiB, and it may be useful for the check to test for this and notify the user that disabling this might be worthwhile.