Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull requests commit messages checks #47

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

javihernandez
Copy link
Member

By default, all commit messages in PRs will be checked to ensure that the lines length don't exceed 72 characters.

Also, ensure that the title or description of the PR includes a link to the issue that has been fixed/resolved. Allowed patterns are:

Note that it checks the PR title/description, which by default is taken from the first commit added into the PR. This way we ensure that:

  • In case of a single commit PR, the commit message includes a resolves/fixes reference.
  • In case of multiple commits PR, the first message might not include such reference, and it must be added manually when merging the PR into the main branch. Note that, the title or description of the PR must include such reference, which can be updated manually anytime.

Fixes: AlmaLinux/build-system#146

By default, all commit messages in PRs will be checked to ensure that
the lines length don't exceed 72 characters.

Also, ensure that the title or description of the PR includes a link to
the issue that has been fixed/resolved. Allowed patterns are:

* Fixes AlmaLinux/build-system#1234
* Resolves: https://github.com/AlmaLinux/build-system/issues/1234

Note that it checks the PR title/description, which by default is
taken from the first commit added into the PR. This way we ensure that:

* In case of a single commit PR, the commit message includes a
  resolves/fixes reference.
* In case of multiple commits PR, the first message might not include
  such reference, and it must be added manually when merging the PR into
  the main branch. Note that, the title or description of the PR must
  include such reference, which can be updated manually anytime.

Fixes: AlmaLinux/build-system#146
@Korulag Korulag merged commit 74221e6 into AlmaLinux:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Commit Message Check GH action doesn't work
3 participants