Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data corruption, Port [#18525] to branch-2.10 #18546

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

jja725
Copy link
Contributor

@jja725 jja725 commented Mar 12, 2024

What changes are proposed in this pull request?
This fix a bug in corrupted data files.
Previously, #17497 attempt to solve this issue but only covers the case when creating a UFS reader
Notice we only handle block reader. So this may not fix paged Block Reader in 2.x

Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys

[This is an auto-generated PR to cherry-pick committed PR https://github.com//pull/18525 into branch branch-2.10]

### What changes are proposed in this pull request?

A this fix a bug in corrupted data files.
Previously,  Alluxio#17497 attempt to solve this issue but only covers the case when creating a UFS reader
Notice we only handle block reader. So this may not fix `paged Block Reader` in 2.x 
### Why are the changes needed?

Please clarify why the changes are needed. For instance,
  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

### Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including
  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

			pr-link: Alluxio#18525
			change-id: cid-bbba0feb29231e70750e5e79da5f405bb591d47a
@jja725 jja725 requested a review from yuzhu March 12, 2024 22:10
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("Cherry") is not an imperative verb. Please use one of the valid words
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@jja725 jja725 force-pushed the cherry-pick-data-corruption branch from 8461597 to aab5259 Compare March 12, 2024 22:26
@yuzhu yuzhu changed the title Cherry pick data corruption Fix data corrupted issue when loading f...; Port [#18525] to branch-2.10 Mar 12, 2024
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@yuzhu yuzhu changed the title Fix data corrupted issue when loading f...; Port [#18525] to branch-2.10 Fix data corrupted issue when loading; Port [#18525] to branch-2.10 Mar 12, 2024
@yuzhu yuzhu changed the title Fix data corrupted issue when loading; Port [#18525] to branch-2.10 Fix data corruption, Port [#18525] to branch-2.10 Mar 12, 2024
Copy link
Contributor

@yuzhu yuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuzhu
Copy link
Contributor

yuzhu commented Mar 12, 2024

alluxio-bot, merge this please

@alluxio-bot
Copy link
Contributor

merge failed:
Merge refused because pull request does not have label start with type-

@yuzhu
Copy link
Contributor

yuzhu commented Mar 12, 2024

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit cbbd5b9 into Alluxio:branch-2.10 Mar 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants