Remove table module (2nd attempt) #17762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fully remove the Table module and related properities and proto This reverts commit c8d6991.
|
@JiamingMai @beinan, the first commit simply removes the table module by reverting the revert PR made by @JiamingMai. The second commit is the critical one that enables building with older versions of Trino/Presto. It does so by maintaining a select few necessary files. |
beinan
approved these changes
Jul 12, 2023
|
alluxio-bot, merge this please |
|
merge failed: |
apc999
added
area-structured-data
|
alluxio-bot, merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This commit represents a second effort at removing the table module along with its associated definitions and properties. Our initial attempt, PR #17220, was reverted due to a conflict with Presto and Trino codebases, as some removed classes were still being referenced.
Unlike the previous attempt, this commit ensures that all externally referenced classes (e.g., TableMasterClient.java) remain within the codebase to prevent blocking older Presto/Trino builds with newer Alluxio clients post table module removal.
Why are the changes needed?
Structured data service gets depreciated in 2.9 and should be removed in 300 or later.
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including