Add Etcd membership module #17736

lucyge2022 · 2023-07-05T22:22:46Z

What changes are proposed in this pull request?

Add membership module for dora membership management.

Why are the changes needed?

Allow usage of etcd cluster or static configuration instead of Master for membership management

Does this PR introduce any user facing changes?

No

alluxio-bot · 2023-07-05T22:53:09Z

Automated checks report:

PR title follows the conventions: FAIL
- The title of the PR does not pass all the checks. Please fix the following issues:
  - First word of title ("Etcd") is not an imperative verb. Please use one of the valid words
Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

alluxio-bot · 2023-07-06T00:18:37Z

Automated checks report:

PR title follows the conventions: PASS
Commits associated with Github account: PASS

All checks passed!

jenoudet

Are there plans to introduce dependency injection through Guice to this new code? That would match the rest of the worker code.

dora/core/common/src/main/java/alluxio/Constants.java

dora/core/client/fs/src/main/java/alluxio/client/metrics/MetricsHeartbeatContext.java

dora/core/common/src/main/java/alluxio/Constants.java

jenoudet · 2023-07-06T20:20:27Z

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

+  public void connect() {
+    connect(false);
+  }
+
+  public void connect(boolean force) {
+    if (mConnected.get() && !force) {
+      return;
+    }
+    mConnected.set(false);
+    // create client using endpoints
+    Client client = Client.builder().endpoints(mEndpoints)
+        .build();
+    if (mConnected.compareAndSet(false, true)) {
+      mClient = client;
+    }
+  }
+


Client creation should equal client connection, as is the case for gRPC clients and raw etcd clients. wdyt?

i actually refer to AbstractClient.connect() which is called within retryRpcInternal, and got triggered on first rpc call made to grpc services. Therefore AlluxioEtcdClient.connect() is getting called on first usage of itself, like getEtcdClient(), start a new ServiceDiscovery() instance where the instantiation is embedded in AlluxioEtcdClient constructor, so in a way, AlluxioEtcdClient.connect gets called at time of instantiation.

dora/core/common/src/main/java/alluxio/membership/ServiceDiscoveryRecipe.java

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

dora/core/common/src/main/java/alluxio/membership/EtcdMembershipManager.java

dbw9580

Thanks Lucy, amazing work! I have some comments from a perspective of a consumer (e.g. worker selection policies) of this API.

dbw9580 · 2023-07-10T09:06:31Z

dora/core/common/src/main/java/alluxio/membership/MembershipManager.java

+   * @return all registered workers
+   * @throws IOException
+   */
+  public List<WorkerInfo> getAllMembers() throws IOException;


Can we make the return type a dedicated data structure? e.g. a ClusterMembershipView that allows doing things more efficiently?

checking if a worker is a member of the cluster

This is more efficient if done with a Set instead of a List.

checking if two view snapshots are the same, and

calculating the diff between two view snapshots

These two are useful for worker selection policies to tell if it is necessary to invalidate their cached view of the cluster members. For example WorkerLocationPolicy.ConsistentHashProvider currently caches the list of workers to save the cost of rebuilding a hash ring every time when called to decide the preferred worker for a file.

seletively querying workers by their properties, e.g. liveness

So that you can move the getLiveMemebers getFailedMember methods to the view object and make this interface cleaner.

like public ClusterMembershipView getView() {
return new ClusterMembershipView()
}
ClusterMembershipView {
equals();
getLiveMembers
getFailedMembers
}
like this?

Yes exactly!

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java

dora/core/common/pom.xml

dora/core/common/src/main/java/alluxio/MembershipType.java

apc999

thanks for the PR! this is my 1st batch of comments mostly on style and readability. I didn't get into details of the logics

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

apc999 · 2023-07-10T17:59:14Z

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

+  private static final Lock INSTANCE_LOCK = new ReentrantLock();
+  @GuardedBy("INSTANCE_LOCK")
+  private static final AtomicReference<AlluxioEtcdClient> ALLUXIO_ETCD_CLIENT = new AtomicReference<>();
+  protected AtomicBoolean mConnected = new AtomicBoolean(false);


why do we need this mMember to be protected and not final ?

think u meant mConnected?
changed to private final

dora/core/common/src/main/java/alluxio/membership/BarrierRecipe.java

dora/core/common/src/main/java/alluxio/util/CommonUtils.java

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

dora/core/common/src/main/java/alluxio/membership/BarrierRecipe.java

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

dora/core/common/src/main/java/alluxio/MembershipType.java

Xenorith

cleanup related comments

conf/etcd.conf

conf/etcd.service

dora/core/common/pom.xml

dora/core/common/src/main/java/alluxio/Constants.java

dora/core/server/worker/src/main/java/alluxio/worker/AlluxioWorker.java

dora/core/server/worker/src/main/java/alluxio/worker/dora/PagedDoraWorker.java

dora/tests/src/test/java/alluxio/client/cli/fsadmin/command/DoctorCommandIntegrationTest.java

dora/tests/src/test/java/alluxio/server/worker/WorkerMetadataSyncIntegrationTest.java

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

dora/core/common/src/main/java/alluxio/Constants.java

dora/core/common/src/main/java/alluxio/membership/EtcdMembershipManager.java

dora/core/common/src/main/java/alluxio/membership/ServiceDiscoveryRecipe.java

Xenorith

non java changes look good to me

jiacheliu3

Hey sorry I just submitted a 1st batch of comments as I haven't fully read the longest few classes. I will try to finish very soon.

dora/core/common/src/main/java/alluxio/cli/AbstractShell.java

jiacheliu3 · 2023-07-26T04:09:37Z

dora/core/common/src/main/java/alluxio/membership/BarrierRecipe.java

+    try {
+      GetResponse getResp = mClient.getKVClient().get(
+          ByteSequence.from(mBarrierPath, StandardCharsets.UTF_8)).get();
+      LOG.info("get key:{}, [{}]", mBarrierPath, getResp.getKvs());


will this be noisy for INFO log?

actually this class is not used anywhere, but keeping it thinking it might be useful in future, will remove it as part of this PR

dora/core/common/src/main/java/alluxio/membership/BarrierRecipe.java

dora/tests/src/test/java/alluxio/client/cli/fsadmin/command/DoctorCommandIntegrationTest.java

dora/tests/src/test/java/alluxio/server/worker/WorkerMetadataSyncIntegrationTest.java

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

dora/core/common/src/main/java/alluxio/membership/BarrierRecipe.java

dora/core/common/src/main/java/alluxio/membership/ServiceEntity.java

jiacheliu3 · 2023-07-26T08:20:24Z

dora/shell/src/main/java/alluxio/cli/fsadmin/command/ReportCommand.java

@@ -83,7 +84,8 @@ enum Command {
    SUMMARY, // Report cluster summary
    UFS, // Report under filesystem information
    JOBSERVICE, // Report job service metrics information
-    PROXY // Report proxy information in the cluster
+    PROXY, // Report proxy information in the cluster


we use bin/alluxio fsadmin report capacity to list all workers and their capacity. Does that overlap with what you are doing here?

this doesn't report any worker capacity info, only the live/fail status of each worker

jiacheliu3

Sorry about the delay! I just added the rest of my comments. Honestly majority of those are about formatting and readability, with a few sanity checks for potential catches. PTAL, thanks!

dora/core/common/src/main/java/alluxio/membership/MembershipManager.java

jiacheliu3 · 2023-07-27T02:17:48Z

dora/core/common/src/main/java/alluxio/membership/MembershipManager.java

        case STATIC:
          return new StaticMembershipManager(conf);
        case ETCD:
          return new EtcdMembershipManager(conf);
        case NOOP:
          return new NoOpMembershipManager();
        default:
-          throw new IOException("Unrecognized Membership Type.");
+          throw new IllegalStateException("Unrecognized Membership Type");


nit: what this type is when unrecognized

it would directly throw exception without returning any type

i mean i think you can log the unrecognized type in the exception for better troubleshooting, just a nit

jiacheliu3 · 2023-07-27T02:20:17Z

conf/etcd/etcd.conf.template

+listen-peer-urls: http://172.31.30.204:2380
+
+# List of comma separated URLs to listen on for client traffic.
+#give ip/hostname of this etcd instance
+listen-client-urls: http://172.31.30.204:2379,http://127.0.0.1:2379


i think an example fits better in comments. So a user wouldn't just copy this config and start and see mysterious errors/behaviors.

jiacheliu3 · 2023-07-27T03:06:58Z

conf/etcd/etcd.service.template

+StandardOutput=append:/var/log/etcd.log
+StandardError=append:/var/log/etcd.err


Mac has /var/log but that belongs to root. I figure it's worth mentioning in a short comment, that one can use this path on Mac but may need sudo. I figure the template file is most useful when one want to test and experience a feature, and that test may very likely happen on Mac instead of linux.

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java

jiacheliu3 · 2023-07-27T03:38:38Z

dora/core/common/src/main/java/alluxio/membership/ServiceEntity.java

+  // revision number of kv pair of registered entity on etcd, used for CASupdate
+  protected long mRevision;
+  public final ReentrantLock mLock = new ReentrantLock();
+  public AtomicBoolean mNeedReconnect = new AtomicBoolean(false);


add some comments about the thread safety requirements and guarantees, as I can't make a reasonable guess based on these fields here. Do you need volatile for the mRevision as you wanna CAS it?

[ADDRESS IN NEXT PR]

jiacheliu3 · 2023-07-27T03:41:17Z

dora/core/common/src/main/java/alluxio/util/HashUtils.java

+ */
+public class HashUtils {
+
+  private static final HashFunction HASH_FUNCTION = murmur3_32_fixed();


nit: this hash func is deprecated but it matters little here

jiacheliu3 · 2023-07-27T03:41:59Z

dora/core/server/master/src/main/java/alluxio/master/scheduler/DefaultWorkerProvider.java

@@ -54,6 +54,11 @@ public List<WorkerInfo> getWorkerInfos() {
    }
  }

+  @Override
+  public List<WorkerInfo> getLiveWorkerInfos() {


just wanted to make sure, this does not throw any declared exception, meaning all errors will be RuntimeException?

there should be, this needs to be further revamped when developing etcd interaction for scheduler

jiacheliu3 · 2023-07-27T03:43:04Z

dora/core/server/worker/src/main/java/alluxio/worker/dora/PagedDoraWorker.java

-            mConf, ServerUserState.global()));
+    // TODO(lucy): temporary fallback logic during transition of removing master dependency
+    if (mMembershipManager instanceof NoOpMembershipManager) {
+      getExecutorService()


add a log here

[ADDRESS IN NEXT PR]

jiacheliu3 · 2023-07-27T03:44:00Z

dora/core/server/worker/src/main/java/alluxio/worker/dora/PagedDoraWorker.java

+      registerToMaster();
+      return;
+    }
+    while (true) {


nit: a little log here, as you might get stuck in this loop?

RetryPolicy has a max duration of attempted retry.

apc999

thanks for the contribution! I left comments, most are about coding convention.

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java

dora/core/common/src/main/java/alluxio/MembershipType.java

apc999 · 2023-07-27T04:37:36Z

dora/core/common/src/main/java/alluxio/conf/PropertyKey.java

+              + "Choose STATIC for pre-configured members."
+              + "Choose ETCD for using etcd for membership management")
+          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
+          .setScope(Scope.WORKER)


this membership type will affect client behavior, correct? if yes, it shall be ALL scope

Suggested change

.setScope(Scope.WORKER)

.setScope(Scope.ALL)

apc999 · 2023-07-27T04:38:47Z

dora/core/common/src/main/java/alluxio/conf/PropertyKey.java

+          .setDescription("Type of membership manager used for workers."
+              + "Choose STATIC for pre-configured members."
+              + "Choose ETCD for using etcd for membership management")
+          .setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)


this is a critical config that all components need to have the same consistent setting.

Suggested change

.setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)

.setConsistencyCheckLevel(ConsistencyCheckLevel.ENFORCE)

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

apc999 · 2023-07-27T07:55:44Z

dora/core/common/src/main/java/alluxio/membership/ServiceEntity.java

+ * Base Entity class including information to register to Etcd
+ * when using EtcdMembershipManager.
+ */
+public class ServiceEntity implements Closeable {


I would make a ServiceEntity interface with the only required methods,
but leaving this implementation like BasicServiceEntry or DefaultServiceEntry.
Actually will there be any one create an instance of this class? I didn't find one though.

Also, this does not look like threadsafe to me

apc999 · 2023-07-27T07:59:47Z

dora/core/common/src/main/java/alluxio/membership/StaticMembershipManager.java

+ * MembershipManager configured by a static file.
+ */
+public class StaticMembershipManager implements MembershipManager {
+  List<WorkerInfo> mMembers;


private final?

apc999 · 2023-07-27T08:04:42Z

dora/core/common/src/main/java/alluxio/membership/StaticMembershipManager.java

+   * @param conf
+   * @throws IOException
+   */
+  public StaticMembershipManager(AlluxioConfiguration conf) throws IOException {


constructors shall be simple and always succeed without throwing Exceptions.

Check alluxio.client.file.cache.LocalCacheManager#create and alluxio.client.file.cache.LocalCacheManager#LocalCacheManager,

create is a static factory method that can through exceptions, while LocalCacheManager is a constructor purely receiving member assignment (absolutely will complete)

Handling a constructor that can throw exceptions is tricky

dora/core/common/src/main/java/alluxio/util/HashUtils.java

apc999 · 2023-07-27T08:18:05Z

dora/core/server/worker/src/main/java/alluxio/worker/dora/PagedDoraWorker.java

  private void register() throws IOException {
+    Preconditions.checkState(mAddress != null, "worker not started");


Suggested change

Preconditions.checkState(mAddress != null, "worker not started");

Preconditions.checkNotNull(mAddress, "worker not started");

jiacheliu3

Thanks a lot for the great work! I'm good except a few doc-related commends like https://github.com/Alluxio/alluxio/pull/17736/files#r1275694116

Despite that there are few comments from Bin which can lead to code changes, I will give my stamp in order not to block the progress. I'll leave the rest to your judgements :P

…ringBuffer else where on frequent paths

2. use conf/workers as default static worker membership mgr typed file and use existing util to parse it accordingly

…ration of thread safety / atomicity / race condition addressing in doc. Remove unwanted lock. 2. Close MembershipManager properly in Worker close & FileSystemContext closeContext 3. address more review comments

apc999

Please address in this PR (git related)

the change in this PR for dora/core/server/worker/src/main/java/alluxio/worker/AlluxioWorker.java looks like a regression from main branch. please fix it
change in dora/tests/pom.xml also looks like a rebase regression

In follow up PR

please remember address comments w.r.t. potential stream resource leak in dora/core/common/src/main/java/alluxio/membership/EtcdMembershipManager.java.

apc999 · 2023-08-01T04:28:57Z

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java

+      try (AutoCloseable ignoredCloser = mMembershipManager) {
+        // do nothing as we are closing
+      } catch (Exception e) {
+        throw new IOException(e);
+      }


is this necessary since there is nothing inside the try-catch block?
how is this different from simply calling mMembershipManager.close()?

apc999 · 2023-08-01T04:35:03Z

dora/core/common/src/main/java/alluxio/conf/PropertyKey.java

+  public static final PropertyKey ALLUXIO_CLUSTER_NAME =
+      stringBuilder(Name.ALLUXIO_CLUSTER_NAME)
+          .setDefaultValue("DefaultAlluxioCluster").build();
+  public static final PropertyKey ETCD_ENDPOINTS =


please address this also in the next PR @lucyge2022

apc999 · 2023-08-01T04:39:38Z

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

+ * its atomicity/consistency semantics goes with what ETCD has to offer, this class
+ * does not add upon any semantics itself.
+ *
+ * AlluxioEtcdClient should only be used as singleton wrapping one jetcd Client object,


very helpful javadoc!

apc999 · 2023-08-01T04:52:51Z

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

+   * @param watchType
+   */
+  private void addListenerInternal(
+      String parentPath, StateListener listener, WatchType watchType) {


do we need to check if parentPath is not an empty String?

apc999 · 2023-08-01T04:55:51Z

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

+                  break;
+                case UNRECOGNIZED: // Fall through
+                default:
+                  LOG.info("Unrecognized event:{} on watch path of:{}",


apc999 · 2023-08-01T05:11:09Z

dora/core/common/src/main/java/alluxio/membership/ServiceDiscoveryRecipe.java

+      try {
+        unregisterService(entry.getKey());
+      } catch (IOException ex) {
+        LOG.info("Unregister all services failed unregistering for:{}.", entry.getKey(), ex);


apc999 · 2023-08-01T05:12:03Z

dora/core/common/src/main/java/alluxio/membership/ServiceDiscoveryRecipe.java

+            newLeaseInternal(entity);
+            entity.mNeedReconnect.set(false);
+          } catch (IOException e) {
+            LOG.info("Failed trying to new the lease for service:{}", entity, e);


apc999 · 2023-08-01T05:16:22Z

dora/core/common/src/main/java/alluxio/membership/StaticMembershipManager.java

+  }
+
+  @Override
+  @VisibleForTesting


Remove @VisibleForTesting in the following methods.
we just need it in the interface, only for these methods only exposed for testing

apc999 · 2023-08-01T05:21:32Z

dora/shell/src/main/java/alluxio/cli/fsadmin/command/ReportCommand.java

@@ -229,7 +238,8 @@ public static String description() {
        + "    metrics          metrics information\n"
        + "    summary          cluster summary\n"
        + "    ufs              under storage system information\n"
-        + "    jobservice       job service metrics information\n";
+        + "    jobservice       job service metrics information\n"
+        + "    nodestatus       node status [worker as of now]\n";


feel free to leave it next pr, but we shall just call this cmd either status or nodes (workers).

[ADDRESS IN NEXT PR]

It's not part of ReportCommand anymore, I have created another fsadmin cmd, named "nodes", we can do showstatus or other admin functionalities such as remove nodes over there.
introduced in #17890
e.g.
$bin/alluxio fsadmin nodes status

apc999 · 2023-08-01T05:21:53Z

dora/tests/pom.xml

@@ -88,6 +88,7 @@
    <dependency>
      <groupId>org.testcontainers</groupId>
      <artifactId>testcontainers</artifactId>
+      <version>1.14.3</version>


…u master

lucyge2022 · 2023-08-01T21:52:20Z

alluxio-bot, merge this please

alluxio-bot · 2023-08-01T21:52:21Z

merge failed:
Merge refused because pull request does not have label start with type-

lucyge2022 · 2023-08-01T21:53:12Z

alluxio-bot, merge this please

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java

Xenorith · 2023-08-17T19:43:16Z

dora/core/common/src/main/java/alluxio/conf/PropertyKey.java

+  //
+  public static final PropertyKey ALLUXIO_CLUSTER_NAME =
+      stringBuilder(Name.ALLUXIO_CLUSTER_NAME)
+          .setDefaultValue("DefaultAlluxioCluster").build();


why aren't all the builder fields being set? specifically

for ALLUXIO_CLUSTER_NAME: setDescription, setScope, setConsistencyCheckLevel

for WORKER_MEMBERSHIP_ETCD_ENDPOINTS: setScope, setConsistencyCheckLevel

oh i think i missed it, let me add it, is it causing any problems now?

not yet but... 🤷

lucyge2022 marked this pull request as ready for review July 5, 2023 22:25

lucyge2022 force-pushed the etcd-membership branch from d138857 to aa46aa4 Compare July 5, 2023 22:53

lucyge2022 changed the title ~~Etcd membership~~ Add Etcd membership module Jul 6, 2023

jenoudet reviewed Jul 6, 2023

View reviewed changes

dbw9580 reviewed Jul 10, 2023

View reviewed changes

apc999 reviewed Jul 10, 2023

View reviewed changes

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java Outdated Show resolved Hide resolved

apc999 reviewed Jul 10, 2023

View reviewed changes

dora/core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java Show resolved Hide resolved

apc999 reviewed Jul 10, 2023

View reviewed changes

dora/core/common/pom.xml Outdated Show resolved Hide resolved

apc999 reviewed Jul 10, 2023

View reviewed changes

dora/core/common/src/main/java/alluxio/MembershipType.java Outdated Show resolved Hide resolved

apc999 requested changes Jul 10, 2023

View reviewed changes

lucyge2022 force-pushed the etcd-membership branch 4 times, most recently from 1d56796 to f8ffeed Compare July 24, 2023 23:50

Xenorith reviewed Jul 25, 2023

View reviewed changes

yyongycy reviewed Jul 25, 2023

View reviewed changes

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java Show resolved Hide resolved

Xenorith reviewed Jul 25, 2023

View reviewed changes

Xenorith approved these changes Jul 25, 2023

View reviewed changes

jenoudet approved these changes Jul 26, 2023

View reviewed changes

jiacheliu3 requested changes Jul 26, 2023

View reviewed changes

jiacheliu3 requested changes Jul 27, 2023

View reviewed changes

apc999 requested changes Jul 27, 2023

View reviewed changes

jiacheliu3 approved these changes Jul 28, 2023

View reviewed changes

lucyge2022 added 5 commits July 31, 2023 11:16

etcd membership WIP

a6829a0

move class

9647bd6

WIP - service discovery changes

8779d7f

stash changes locally

38e2f53

WIP - integrate membership into worker process

f158b51

lucyge2022 added 12 commits July 31, 2023 11:20

avoid string concatenation

1e9d688

make sure string.format is used only for one-time codepath and use St…

80a5879

…ringBuffer else where on frequent paths

add more elaboration in etcd.conf and remove unused file

0816af0

more review comments / comments

b5f9614

missing license header

4a32caf

1. PropertyKey field name changes

4a5b49e

2. use conf/workers as default static worker membership mgr typed file and use existing util to parse it accordingly

method name change

fe0bf2f

review comments

a26bf2e

singleton logic change

ef18bc5

move static fields togehter

3bc06b2

review comments

1078c16

1. ServiceDiscoveryRecipe: fix atomicity update guarantee, more elabo…

c87bce8

…ration of thread safety / atomicity / race condition addressing in doc. Remove unwanted lock. 2. Close MembershipManager properly in Worker close & FileSystemContext closeContext 3. address more review comments

lucyge2022 force-pushed the etcd-membership branch from d6541e6 to c87bce8 Compare July 31, 2023 18:22

lucyge2022 added 2 commits July 31, 2023 11:25

checkstyle fix

7ffe87f

findbugs fix

cdc733b

apc999 approved these changes Aug 1, 2023

View reviewed changes

yyongycy mentioned this pull request Aug 1, 2023

Remove BlockMasterSync in the worker #17870

Open

lucyge2022 added 5 commits August 1, 2023 11:27

remove unwanted checkins due to rebasing

66be616

close resource properly & more review comments

3224225

ignore tests no longer needed

7da6f45

checkstyle

e0327ad

comment out tests which needs confirmation of worker registration thr…

28c04c1

…u master

lucyge2022 added the type-feature This issue is a feature request label Aug 1, 2023

alluxio-bot merged commit 20eac74 into Alluxio:main Aug 1, 2023
11 checks passed

yyongycy reviewed Aug 3, 2023

View reviewed changes

dora/core/common/src/main/java/alluxio/membership/AlluxioEtcdClient.java Show resolved Hide resolved

lucyge2022 added a commit to lucyge2022/alluxio that referenced this pull request Aug 9, 2023

more review comments from Alluxio#17736

bfa05f1

Xenorith reviewed Aug 17, 2023

View reviewed changes

		StandardOutput=append:/var/log/etcd.log
		StandardError=append:/var/log/etcd.err

	.setConsistencyCheckLevel(ConsistencyCheckLevel.WARN)
	.setConsistencyCheckLevel(ConsistencyCheckLevel.ENFORCE)

		private void register() throws IOException {
		Preconditions.checkState(mAddress != null, "worker not started");

	Preconditions.checkState(mAddress != null, "worker not started");
	Preconditions.checkNotNull(mAddress, "worker not started");

Add Etcd membership module #17736

Add Etcd membership module #17736

Conversation

lucyge2022 commented Jul 5, 2023

What changes are proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user facing changes?

alluxio-bot commented Jul 5, 2023

alluxio-bot commented Jul 6, 2023

jenoudet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbw9580 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apc999 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xenorith left a comment

Choose a reason for hiding this comment

Xenorith left a comment

Choose a reason for hiding this comment

jiacheliu3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiacheliu3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apc999 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiacheliu3 left a comment

Choose a reason for hiding this comment

apc999 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apc999 left a comment •

edited

Loading