[SMALLFIX] Fix logging message template in AlluxioMasterProcess #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xwzbupt, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @xwzbupt! Thank you for signing the Contribution License Agreement. |
dbw9580
changed the title
dbw9580
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
LGTM, thanks!
@jiacheliu3 please merge this once the unit tests pass.
|
known flakey test: |
|
alluxio-bot, merge this please |
yyongycy
pushed a commit
to yyongycy/alluxio
that referenced
this pull request
Jan 6, 2022
### What changes are proposed in this pull request?
Modify the placeholder from "%s" to "{}" in the LOG statement.
### Why are the changes needed?
Please clarify why the changes are needed. For instance,
1. The performance of `{}` is better than `%s`，considering `%s` will
cause memory overhead and generate temporary objects.
### Does this PR introduce any user facing changes?
No.
Fixes Alluxio/Community#617
pr-link: Alluxio#14683
change-id: cid-7ef21fd8246ae2c0b952aabb82f043050356fb6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Modify the placeholder from "%s" to "{}" in the LOG statement.
Why are the changes needed?
Please clarify why the changes are needed. For instance,
{}is better than%s，considering%swill cause memory overhead and generate temporary objects.Does this PR introduce any user facing changes?
No.
Fixes Alluxio/Community#617