Fix logging message template in AlluxioMasterProcess #617
Comments
|
/assign @xwzbupt |
alluxio-bot
pushed a commit
to Alluxio/alluxio
that referenced
this issue
Dec 16, 2021
### What changes are proposed in this pull request?
Modify the placeholder from "%s" to "{}" in the LOG statement.
### Why are the changes needed?
Please clarify why the changes are needed. For instance,
1. The performance of `{}` is better than `%s`，considering `%s` will
cause memory overhead and generate temporary objects.
### Does this PR introduce any user facing changes?
No.
Fixes Alluxio/Community#617
pr-link: #14683
change-id: cid-7ef21fd8246ae2c0b952aabb82f043050356fb6c
|
Fixed by Alluxio/alluxio#14683 |
yyongycy
pushed a commit
to yyongycy/alluxio
that referenced
this issue
Jan 6, 2022
### What changes are proposed in this pull request?
Modify the placeholder from "%s" to "{}" in the LOG statement.
### Why are the changes needed?
Please clarify why the changes are needed. For instance,
1. The performance of `{}` is better than `%s`，considering `%s` will
cause memory overhead and generate temporary objects.
### Does this PR introduce any user facing changes?
No.
Fixes Alluxio/Community#617
pr-link: Alluxio#14683
change-id: cid-7ef21fd8246ae2c0b952aabb82f043050356fb6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The logging message template in
AlluxioMasterProcessshould use{}as a placeholder, instead of%s.Change this line of code:
https://github.com/Alluxio/alluxio/blob/e0bd13efcf98c79ef7d7848a22a48fe0408c1680/core/server/master/src/main/java/alluxio/master/AlluxioMasterProcess.java#L194
to
The text was updated successfully, but these errors were encountered: