Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor open ephys package #104

Closed
9 of 11 tasks
mekhlakapoor opened this issue Aug 5, 2024 · 2 comments
Closed
9 of 11 tasks

Refactor open ephys package #104

mekhlakapoor opened this issue Aug 5, 2024 · 2 comments
Assignees

Comments

@mekhlakapoor
Copy link
Contributor

mekhlakapoor commented Aug 5, 2024

User story

As a developer, I want each of the packages in the metadata-mapper to have a JobSettings.

Acceptance criteria

  • Create a module for models in the open_ephys package
  • Create a JobSettings class that inherits BaseJobSettings in new module
  • Move the parameters currently being inputted into the ETL to JobSettings, and add a Literal field job_settings_name
  • Pass job_settings to ETL and refactor ETL methods to retrieve info from job_settings
  • Add OpenEphysJobSettings to SessionJobSettings Union in models.py

Sprint Ready Checklist

  • 1. Acceptance criteria defined
  • 2. Team understands acceptance criteria
  • 3. Team has defined solution / steps to satisfy acceptance criteria
  • 4. Acceptance criteria is verifiable / testable
  • 5. External / 3rd Party dependencies identified
  • 6. Ticket is prioritized and sized

Notes

Look at bergamo package as example

@arjunsridhar12345
Copy link
Collaborator

arjunsridhar12345 commented Sep 12, 2024

working on this

@mekhlakapoor
Copy link
Contributor Author

Closing this issue as completed. Carter's refactor in #174 finished the first few criteria, and there's a new issue for the remaining part (adding it to GatherMetadata job #176)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants