Update build process for MacOS desktop app #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswallace
requested review from
kmitcham,
pgarrison,
SeanLeRoy and
BrianWhitneyAI
BrianWhitneyAI
approved these changes
Jan 8, 2025
kmitcham
reviewed
Jan 9, 2025
kmitcham
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build script creates dmg files for the desktop app that, when downloaded from GitHub/shared via Slack, show the following error for M chip Macs:
This PR updates
desktop/package.jsonto what was used to get the v8.0.0 build working for arm64 (also currently works for x86, though only when run on a computer with an Intel chip).Also adds info to the dev docs about how we currently build & release for MacOS.
For more details on why we have to do separate builds for Mac, see #173