Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/build executable script #381

Merged
merged 6 commits into from
Jan 3, 2025
+2,357 −1,136
Merged

Feature/build executable script #381

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
547a05b
upgrade node and electron to enable building executables locally
aswallace Jan 3, 2025
75493d2
remove electron-devtools-installer dependency
aswallace Jan 3, 2025
71634e5
attempt to update integration yaml file
aswallace Jan 3, 2025
7618c13
update node version in yml and README
aswallace Jan 3, 2025
6bf9f7c
add details to deployment readme
aswallace Jan 3, 2025
4fcec6b
fix minor typos in deployment docs
aswallace Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aws-deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8
with:
node-version: 16
node-version: 18

- name: Install Dependencies
run: npm ci
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Install Dependencies
run: npm ci
Expand All @@ -42,7 +42,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Install Dependencies
run: npm ci
Expand All @@ -60,7 +60,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Install Dependencies
run: npm ci
Expand All @@ -78,7 +78,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Install Dependencies
run: npm ci
Expand All @@ -100,7 +100,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Build Electron app
uses: AllenCellSoftware/action-electron-builder@fms-file-explorer
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@main
with:
node-version: 16
node-version: 18

- name: Build/release Electron app
uses: AllenCellSoftware/action-electron-builder@fms-file-explorer
Expand Down
4 changes: 2 additions & 2 deletions dev-docs/02-setup-and-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ To help with the management of three interconnected packages, this project makes


### System requirements
1. NodeJS version 16.x (use `nvm` or similar)
2. NPM version 8.x
1. NodeJS version 18.x (use `nvm` or similar)
2. NPM version 10.x


### Initial setup
Expand Down
Loading
Loading