Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying_rigid_affine_tps_ra #256

Merged
merged 14 commits into from
Sep 25, 2024
Merged

applying_rigid_affine_tps_ra #256

merged 14 commits into from
Sep 25, 2024

Conversation

rathsidd
Copy link
Collaborator

new module first attempt for applying multiple transforms

@RussTorres RussTorres marked this pull request as draft July 31, 2024 22:48
@RussTorres RussTorres marked this pull request as ready for review August 20, 2024 16:25
@rathsidd rathsidd marked this pull request as draft August 20, 2024 21:12
….py to include ArgSchema and DefaultSchema into the scham type for the module
@rathsidd rathsidd marked this pull request as ready for review August 29, 2024 22:32
Copy link
Collaborator

@RussTorres RussTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are errors that would affect running this as it is committed -- are there more commits missing, or is it possible lines are not being hit when you ran it?

Most of the issues here can be flagged by a good linter, but I tried to capture those and more specific problems in the comments.

@RussTorres RussTorres self-requested a review September 25, 2024 19:13
@RussTorres RussTorres merged commit 42b9f37 into develop Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants