-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMakeLists.txt (etc...) to sdist #90
Comments
ok I think the sdist wants to see a MANIFEST.in file that lists out all the source files to be included. (reference: pytorch/pytorch#52843) |
manifest.in is one option (the "classic distutils option") for declaring what should get into the sdist, but if you're using setuptools, it gets slightly more complicated. suggest reading this page: https://setuptools.pypa.io/en/latest/userguide/datafiles.html and note the Ultimately, as many times as I've read through those docs, I generally end up doing this by some degree of trial and error. running |
I have attempted to do this in the aicspylibczi 3.1.1 build. Still untested but the sdist now has a more complete attempt to bundle all source code. (Gotta figure out how to test this!) |
#89 added the sdist to pypi, which is great. However, in trying to build this package on conda-forge, I pulled the sdist from pypi and tried to build, but the sdist doesn't contain
CMakeLists.txt
(and perhaps other things) required to actually build the source.error
I can use the tar.gz from the github releases for now, but it would be nice to make the sdist fully "build-competent"
The text was updated successfully, but these errors were encountered: