-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin/support-py311 #446
admin/support-py311 #446
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 48 48
Lines 4279 4279
=======================================
Hits 4031 4031
Misses 248 248
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ubuntu-20.04, | ||
ubuntu-latest, | ||
windows-latest, | ||
macos-11, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason these were pinned?
AllenCellModeling/aicspylibczi#110 might be a start for making this work |
Did we decide to postpone this until after the refactor? @evamaxfield |
I may have said that -- but it was likely me misspeaking. I primarily use py311 now so I would say that we should have a release of aicsimageio that supports it. Our upstreams are the problem tho. I will rerun this just to see what happens. |
Oh! The issue here isn't someone elses upstream, it's our own upstream. The only failing tests (besides docs) look to be CZI tests because we haven't release support for 3.11 on aicspylibczi yet. @toloudis has the best knowledge outside of Jamie but I think the change we need to make is here: https://github.com/AllenCellModeling/aicspylibczi/blob/9c9d62630275a71fd7c5832fd3300f64a0c89e29/.github/workflows/PublishLinux.yml#L22 ?? I have no idea how to add support for new python versions in that lib. |
AllenCellModeling/aicspylibczi#110 |
hm, the pip install of aicspylibczi 3.1.0 is now failing. Not sure how to remedy this yet. It seems to want to build from source, which means we need to pack up all the c++ code into the tar.gz artifact. |
coming soon : aicspylibczi 3.1.1 with proper wheels for python 3.11 |
the new aicspylibczi build has proper 3.11 support and all the tests passing now! |
try to bump Pillow to first version supporting 3.11
Description
Opening to see what breaks. Python 3.11 support is slowly rolling out to different libraries so we should track this and see when we can do it too.
Thanks for contributing!