Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Docs-README-Mention-mvn/maven-requirement-for-bioformats_jar #463

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

psobolewskiPhD
Copy link
Contributor

Description

As far as I can tell from testing and googling, the bioformats importer requires not just java but also mvn (maven). See:
tlambert03/bioformats_jar#4 (comment)
https://allencellmodeling.github.io/aicsimageio/aicsimageio.readers.html#aicsimageio.readers.bioformats_reader.BioformatsReader

This PR makes this clear(er): mvn is required in addition to java.
Having java is likely to be fairly common or at least understood, but mvn? I'd never heard of it before this, so I think it's best to explicitly mention it.

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [gh-], adds tiff file format support
  • Provide relevant tests for your feature or bug fix. N/A
  • Provide or update documentation for any feature added by your pull request. N/A

Copy link
Collaborator

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @psobolewskiPhD!

@evamaxfield
Copy link
Collaborator

Makes sense to me! Thanks @psobolewskiPhD

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b80eb26) 94.03% compared to head (8667ad2) 94.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          48       48           
  Lines        4155     4155           
=======================================
  Hits         3907     3907           
  Misses        248      248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evamaxfield evamaxfield merged commit 6b02c2f into AllenCellModeling:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants