Bugfix/Docs-README-Mention-mvn/maven-requirement-for-bioformats_jar #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I can tell from testing and googling, the
bioformats
importer requires not justjava
but alsomvn
(maven). See:tlambert03/bioformats_jar#4 (comment)
https://allencellmodeling.github.io/aicsimageio/aicsimageio.readers.html#aicsimageio.readers.bioformats_reader.BioformatsReader
This PR makes this clear(er):
mvn
is required in addition tojava
.Having
java
is likely to be fairly common or at least understood, butmvn
? I'd never heard of it before this, so I think it's best to explicitly mention it.Pull request recommendations: