Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number workflows #37

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Number workflows #37

wants to merge 13 commits into from

Conversation

chantelleleveille
Copy link
Contributor

@chantelleleveille chantelleleveille commented Nov 14, 2024 •
edited
Loading

Main Goal: Update workflow names to indicate which figure in the paper they generate.

For review:

  • please confirm if you like this numbering/naming convention
  • @cfrick13 Please double check s2 and s3 and s18. I did not rename your base workflow files because I wasn't 100p sure what came from where!
  • s17 I think is a code free figure? or can you confirm what workflow it is associated with.

Yay!

I am currently running run all workflows. I will not merge until that finishes and succeeds!

Bonus one line bug fix:

  • Full tracks dataframe was not sorted by index sequence and it was causing plots to look crazy!
before after
Screen Shot 2024-11-14 at 2 21 20 PM Screen Shot 2024-11-14 at 2 22 08 PM

@chantelleleveille chantelleleveille marked this pull request as ready for review November 14, 2024 23:07
@jcass11
Copy link
Contributor

jcass11 commented Nov 15, 2024

  • Checked all the new referenced fig numbers and they all match the right figures ✅
  • Naming convention and organization all looks good to me
  • Yes I believe S17 is code-free
  • Thanks for the bug fix!

jcass11
jcass11 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jcass11 jcass11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like @chantelleleveille is going to run all workflows so I am approving without running. Thank you!

nuc_morph_analysis/lib/preprocessing/filter_data.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcass11 jcass11 jcass11 approved these changes

@pgarrison pgarrison Awaiting requested review from pgarrison

@cfrick13 cfrick13 Awaiting requested review from cfrick13

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chantelleleveille @jcass11