refactor: optimize AllayCHunk#tick()

AllayMC · Sep 15, 2024 · 6d9ef9b · 6d9ef9b
1 parent 3e0d917
commit 6d9ef9b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/Allay-Server/src/main/java/org/allaymc/server/AllayServer.java b/Allay-Server/src/main/java/org/allaymc/server/AllayServer.java
@@ -266,12 +266,12 @@ public void onDisconnect(EntityPlayer player) {
 
         if (player.isLoggedIn()) {
             broadcastTr(TextFormat.YELLOW + "%" + TrKeys.M_MULTIPLAYER_PLAYER_LEFT, player.getOriginName());
-            playerStorage.savePlayerData(player);
             players.remove(player.getUUID());
         }
 
         if (player.isSpawned()) {
             player.getDimension().removePlayer(player);
+            playerStorage.savePlayerData(player);
 
             var pk = new PlayerListPacket();
             pk.setAction(PlayerListPacket.Action.REMOVE);

diff --git a/Allay-Server/src/main/java/org/allaymc/server/world/chunk/AllayChunk.java b/Allay-Server/src/main/java/org/allaymc/server/world/chunk/AllayChunk.java
@@ -66,12 +66,8 @@ private static void checkXYZ(int x, int y, int z) {
     }
 
     public void tick(long currentTick) {
-        if (!getBlockEntities().isEmpty()) {
-            getBlockEntities().values().forEach(blockEntity -> blockEntity.tick(currentTick));
-        }
-        if (!getEntities().isEmpty()) {
-            getEntities().values().forEach(entity -> entity.tick(currentTick));
-        }
+        getBlockEntities().values().forEach(blockEntity -> blockEntity.tick(currentTick));
+        getEntities().values().forEach(entity -> entity.tick(currentTick));
     }
 
     @Override