Fixes Render.com integration #44
Conversation
| @@ -16,10 +22,9 @@ services: | |||
| fromDatabase: | |||
| name: hostedgpt | |||
| property: connectionString | |||
| - key: RAILS_MASTER_KEY | |||
| - fromGroup: generated-secrets | |||
There was a problem hiding this comment.
This is cool! Can you please also update the README.md file to remove that step of copy/pasting the key?
There was a problem hiding this comment.
Good call. I updated the instructions there a little. We should consider whether forking the repository is necessary for a render deploy -- if not, we can make the process even easier.
| envVars: | ||
| - key: rails_master_key | ||
| generateValue: true | ||
|
|
There was a problem hiding this comment.
Oh, interesting! @robacarp how does this make it so we don’t have to copy that master.key value?
My assumption was: the master.key value is important and the fix would involve telling the rails app to find the key within the master.key file, not within the ENV. But it seems like you’ve fixed it somehow by telling render to generate a new one? Is there a discrepancy between this newly generated value and the value already stored in master.key?
There was a problem hiding this comment.
@krschacht gooooooood question. You're making me question what I did here. I assumed that RAILS_MASTER_KEY was something like SECRET_KEY_BASE but with a new name. Perhaps it is the encryption key for a .env file or something? I didn't do enough research into what this does before suggesting that it could be a randomly generated string.
I'll do some research and get back to it.
|
Lint is failing. :( We really need to remove this ruby linter. I have a GH Issue to go back to the super basic rubocop setup that I initially had. It only enforces a very small number (I think three) rules that I’ve found to actually be universally good. I hate enforcing optional stylistic differences or insignificant white space differences. |
I already created a PR that reverting it back to previous setup. |
|
@robacarp please update your pr with the latest changes in main and lint issue should be resolved |
fixes #43
Also fixes the need to copy/paste a master key in by asking render.com to generate a value when the app is cloned.