Don't need a Current.user for determining LanguageModel#effective_api…

…_name
AllYourBot · Jan 19, 2025 · a48ca2b · a48ca2b
1 parent 15956e9
commit a48ca2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/models/language_model.rb b/app/models/language_model.rb
@@ -40,7 +40,7 @@ def test(api_name = nil)
   def effective_api_name
     if api_name =~ /-best\Z/
       begin
-        Current.user.language_models.best_for_api_service(api_service).first.api_name
+        api_service.language_models.best_for_api_service(api_service).first.api_name # there should be only one.
       rescue => e
         Rails.logger.info "Could not resolve best model for #{api_name} from API service #{api_service.name} : #{e}"
         raise "Could not resolve best model for #{api_name} from API service #{api_service.name}"

diff --git a/test/models/language_model_test.rb b/test/models/language_model_test.rb
@@ -23,7 +23,8 @@ class LanguageModelTest < ActiveSupport::TestCase
     assert_equal "gpt-4o-2024-05-13", language_models(:gpt_4o_2024_05_13).effective_api_name
   end
 
-  test "effective_api_name needs current user when api_name ends in best" do
+  test "effective_api_name fails with message when api_name ends in best" do
+    language_models(:gpt_4o).update!(best: false)
     exc = assert_raises do 
       language_models(:gpt_best).effective_api_name
     end