Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors in runtime/utils directory #6902

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 23, 2025

This PR fixes all mypy errors in the openhands/runtime/utils directory. Changes include:

  • Added missing return type annotations to functions
  • Added missing type annotations to function parameters
  • Fixed Any return type issues
  • Added missing imports
  • Fixed type compatibility issues with libtmux
  • Added proper null checks for optional attributes

All changes are confined to the specified directory.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:977bbb3-nikolaik   --name openhands-app-977bbb3   docker.all-hands.dev/all-hands-ai/openhands:977bbb3

@neubig neubig changed the base branch from feature/strict-mypy-checks to main February 23, 2025 22:47
@neubig neubig self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants