Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy errors in core directory #6901

Merged
merged 18 commits into from
Feb 24, 2025
Merged

Fix mypy errors in core directory #6901

merged 18 commits into from
Feb 24, 2025

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Feb 23, 2025

This PR fixes all mypy errors in the core directory by:

  1. Removing all type: ignore comments and fixing the underlying issues
  2. Properly handling dynamic attributes in LogRecord
  3. Fixing type issues with ImageContent.model_dump() return value
  4. Fixing role type issues in Message class

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:54e50d0-nikolaik   --name openhands-app-54e50d0   docker.all-hands.dev/all-hands-ai/openhands:54e50d0

@neubig neubig changed the base branch from feature/strict-mypy-checks to main February 23, 2025 22:48
@neubig neubig marked this pull request as ready for review February 24, 2025 01:07
@neubig neubig merged commit 8956f92 into main Feb 24, 2025
14 checks passed
@neubig neubig deleted the fix/mypy-core-errors branch February 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants