New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display session ID in CLI mode #6898

Merged

enyst merged 17 commits into main from fix-issue-6417-cli-sid

Feb 24, 2025

Collaborator

enyst commented Feb 23, 2025 •

edited by github-actions bot

Loading

This PR adds the session ID to the CLI output at startup, as requested in issue #6417. This helps users to easily identify their session ID when using the CLI.

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2704a8c-nikolaik   --name openhands-app-2704a8c   docker.all-hands.dev/all-hands-ai/openhands:2704a8c

enyst force-pushed the fix-issue-6417-cli-sid branch from 9dd0bd0 to 0fb9760 Compare

February 23, 2025 09:40

enyst added the lint-fix label

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved


          feat: display session ID in CLI mode (fix #6417) - including tests an…

25bebae

…d fix ruff error

enyst force-pushed the fix-issue-6417-cli-sid branch from 3f5f3a4 to 25bebae Compare

February 23, 2025 09:59

enyst added lint-fix and removed lint-fix labels


          🤖 Auto-fix Python linting issues

e2bcabd

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved

enyst and others added 2 commits

February 23, 2025 11:04


          Update tests/unit/test_cli_sid.py

ac2c59f


          feat: commit changes with partially corrected test file

9b50fbd

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved


          Update tests/unit/test_cli_sid.py

9afceea

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Show resolved Hide resolved


          Update tests/unit/test_cli_sid.py

7cbb8a4

enyst added lint-fix and removed lint-fix labels


          🤖 Auto-fix Python linting issues

8cd5398

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved

enyst and others added 2 commits

February 23, 2025 11:14


          Update tests/unit/test_cli_sid.py

8f5e627


          fix: mock input() in test_cli_session_id_output to prevent EOFError

0ea83ba

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved


          Update tests/unit/test_cli_sid.py

e97913a

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved

enyst added 2 commits

February 23, 2025 11:51


          Update tests/unit/test_cli_sid.py

74e4bb0


          remove unnecessary

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Outdated Show resolved Hide resolved


          Update tests/unit/test_cli_sid.py

583ae59

enyst commented

View reviewed changes

tests/unit/test_cli_sid.py Show resolved Hide resolved


          Update tests/unit/test_cli_sid.py

28d31f2

openhands-agent added 2 commits

February 23, 2025 12:58


          feat: add assertion to mock_controller fixture to check status_callba…

eb78074

…ck is None


          fix: correct mock_controller fixture to set status_callback=None and …

ebd667c

…remove assertion

tofarr approved these changes

View reviewed changes

Collaborator

tofarr left a comment

🍰


          fix test

2704a8c

enyst marked this pull request as ready for review

February 23, 2025 17:25

enyst enabled auto-merge (squash)

February 23, 2025 17:26

enyst disabled auto-merge

February 23, 2025 17:34

enyst changed the title ~~feat: display session ID in CLI mode (fix #6417)~~ Display session ID in CLI mode

enyst merged commit 666c186 into main

13 checks passed

enyst deleted the fix-issue-6417-cli-sid branch

February 24, 2025 02:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels