Revert "Fix: File Descriptor leak" #6887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6883
Sorry, I can't run
main
this morning, and the interesting part is that the errors are different for different providers. It must be working fine with Anthropic without proxy (direct API call), but not vialitellm_proxy
, and withlog_completions
disabled (I have it enabled).With Claude, directly
With Claude, via litellm proxy:
With o3-mini, directly:
The first can be fixed by just popping out of kwargs the new
client
after the call, but the other two are non-obvious to me at first sight, WDYT?To run this PR locally, use the following command: