Add pause_closed_runtimes config to pause instead of stop runtimes #6885
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotra5
reviewed
Feb 24, 2025
Comment on lines
+384
to
396
| if self.config.sandbox.pause_closed_runtimes: | ||
| try: | ||
| if not self._runtime_closed: | ||
| with self._send_runtime_api_request( | ||
| 'POST', | ||
| f'{self.config.sandbox.remote_runtime_api_url}/pause', | ||
| json={'runtime_id': self.runtime_id}, | ||
| ): | ||
| self.log('debug', 'Runtime paused.') | ||
| except Exception as e: | ||
| self.log('error', f'Unable to pause runtime: {str(e)}') | ||
| raise e | ||
| super().close() |
There was a problem hiding this comment.
It seems super().close() is still called after pausing the runtime? I'm not too familiar with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration variable
pause_closed_runtimes(default: true) that works in conjunction withkeep_runtime_alive. When both are true, the runtime will be paused instead of stopped when closing.Changes:
pause_closed_runtimesconfig variable insandbox_config.pyclose()method inremote_runtime.pyto call/pauseendpoint when both configs are truetruefor better resource managementTo run this PR locally, use the following command: