Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : Improve frontend setup doc and locale error #6850

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

dai-dao
Copy link
Contributor

@dai-dao dai-dao commented Feb 20, 2025

Improve front-end setup for new users


  1. Fix make file to check for node 22 instead of node 20, since installing node 20 doesn't work anymore
  2. Fix i18next to ignore the regional part of the language code entirely, loading only the primary language (e.g., "en"). This helps remove this error from the logs which is annoying.

Can't locate /locale/us-EN/translation.json

  1. Small refactors for the routes folder to use fastAPI defined status codes instead of explicitly using integers

#6633

@enyst enyst requested a review from amanape February 20, 2025 14:34
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes!

@enyst enyst added lint-fix and removed lint-fix labels Feb 21, 2025
@enyst
Copy link
Collaborator

enyst commented Feb 21, 2025

@dai-dao Linting is failing and the automated lint fails too, could you take a look?

@dai-dao
Copy link
Contributor Author

dai-dao commented Feb 21, 2025

@enyst it's fixed ready to merge

@enyst enyst merged commit e109f7e into All-Hands-AI:main Feb 21, 2025
15 checks passed
@enyst
Copy link
Collaborator

enyst commented Feb 21, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants